sql, cli: Add attrs and locality to the node command

[BramGruneir]

This patch fixes a number of aspects about how we display node and store
attributes as well as adds node attributes and localities to the

• The String method on attributes proto was incorrectly using a , to join the
  array. Attributes always use a : so that it can be parsed via the command
  line and this fixes that.
• Also, the internal tables crdb_interal.gossip_nodes,
  crdb_internal.kv_node_status and crdb_internal.kv_store_status had the
  attributes listed as JSON. This is not useful as it won't match what's in the
  command line. This converts it to a string.
• This also adds the node attributes and localities to the
  cockroach node status command. As it was missing and can be helpful.

Release note (cli change): Node attributes and localities have been added to
the cockroach node status command.

[cockroach-teamcity]

This change is 

[BramGruneir]

This is a follow up to #37944. So please ignore the first commit and comment on it in that PR.

Again, this could be backported or not. And I don't know our policy on changing crdb_internal tables.

[knz]

LGTM on the overall result on the CLI (I agree that the CLI commands should print out their result in a format compatible with the command line arguments).

However as to the mechanism, I kind of like the availability of structured data internally. I think it is possible to "flatten" the structured data as an intermediate step, instead of at the source.

Also the CLI example needs a test, you can use the Example_XXXX model in cli_test.go (I think there are zone config / attribute config tests there already).

Reviewed 2 of 2 files at r1, 4 of 4 files at r2.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @andy-kimball and @BramGruneir)

---

pkg/cli/node.go, line 164 at r2 (raw file):

                 END AS is_available,
            ifnull(is_live, false),
            locality,

And here you could use the newly introduced built-in function to render the result.

---

pkg/sql/crdb_internal.go, line 2384 at r2 (raw file):

				tree.NewDString(n.Desc.Address.NetworkField),
				tree.NewDString(n.Desc.Address.AddressField),
				tree.NewDString(n.Desc.Attrs.String()),

Ditto my comments on #37944, I would use JSON here and introduce a built-in function separately.

[bobvawter]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}