Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: logic_test/crdb_internal: add missing comments #38078

Merged
merged 1 commit into from Jun 6, 2019

Conversation

knz
Copy link
Contributor

@knz knz commented Jun 6, 2019

Requested by @rytaft in #38051 (review).

Release note: None

@knz knz requested review from rytaft and a team June 6, 2019 21:30
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thanks!

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@knz
Copy link
Contributor Author

knz commented Jun 6, 2019

TFYR!

bors r+

craig bot pushed a commit that referenced this pull request Jun 6, 2019
38078: sql: logic_test/crdb_internal: add missing comments r=knz a=knz

Requested by @rytaft in #38051 (review).

Release note: None

Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
@craig
Copy link
Contributor

craig bot commented Jun 6, 2019

Build succeeded

@craig craig bot merged commit 9ce651f into cockroachdb:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants