Remove admin privilege for force_retry #39243 #39246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Thanks! There's also a test for this error that needs to be removed (in |
|
@bdarnell you're welcome! |
|
bors r+ |
Build succeeded |
|
@bdarnell, this hasn't changed in our auto-generated functions doc. Still shows up as |
|
Yeah, 'system info functions' is still the right place for it. Nothing needs to change because the admin privilege was removed, but now that we're using this in our examples we should probably give it some actual docs instead of "internal use only". |
rmloveland
added a commit
to cockroachdb/docs
that referenced
this pull request
Sep 12, 2019
Also, delete the comments in the Python code that state that `crdb_internal.force_retry()` must be run as root. This restriction was lifted in cockroachdb/cockroach#39246. The 19.1 Python code samples were updated in #5085 and #5173. We then forgot to port those changes to 19.2. This commit remedies that oversight. Addresses part of #5176.
rmloveland
added a commit
to cockroachdb/docs
that referenced
this pull request
Sep 16, 2019
Also, delete the comments in the Python code that state that `crdb_internal.force_retry()` must be run as root. This restriction was lifted in cockroachdb/cockroach#39246. The 19.1 Python code samples were updated in #5085 and #5173. We then forgot to port those changes to 19.2. This commit remedies that oversight. Addresses part of #5176.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #39243