sql: do not re-create columnFormatCodes if there is a single column. #39310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is only one column and there is only one format code, then there is no need to rebuild the list. We would only need to rebuild the list if there is more than 1 column and only a single format code was provided by the client.
|
This change is |
maddyblue
approved these changes
Aug 5, 2019
|
bors r+ |
Build failed |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 5, 2019
39310: sql: do not re-create columnFormatCodes if there is a single column. r=mjibson a=elliotcourant If there is only one column and there is only one format code, then there is no need to rebuild the list. We would only need to rebuild the list if there is more than 1 column and only a single format code was provided by the client. This was just something I had noticed a while after I had already submitted #38870. Co-authored-by: Elliot Courant <me@elliotcourant.dev>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is only one column and there is only one format code, then
there is no need to rebuild the list. We would only need to rebuild the
list if there is more than 1 column and only a single format code was
provided by the client.
This was just something I had noticed a while after I had already
submitted #38870.