server: improve the status.Ranges RPC #39613
Open
+1,062
−629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also add an option for key ordering besides the existing range id ordering. Release note: None
... to use a replica visitor instead of iterating through range descriptors in the engine. This should be both cheaper (iterate through an in-mem data structure instead of storage, and avoid a lookup per range) and also more standard. Release note: None
Make the set of data it returns controllable by the caller, and make it suitable to be used by the upcoming ranges constraint conformance report. This guy needs way less data than the RPC currently returns - it only needs the descriptor and the lease info. But it needs the results ordered by key. Also add a streaming version, to be used by the reporting code. That client will stream and merge results from all the nodes. Release note: None
|
This change is |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the set of data it returns controllable by the caller, and make it
suitable to be used by the upcoming ranges constraint conformance
report. This guy needs way less data than the RPC currently returns -
it only needs the descriptor and the lease info. But it needs the
results ordered by key.
Also add a streaming version, to be used by the reporting code. That
client will stream and merge results from all the nodes.
Release note: None