ui: fix mixed units in tooltips #40970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This change is |
nathanstilwell
added
the
first-pr
|
@elkmaster You may disregard the this build failure for now. When I release branch is cut the justification requirement will be lifted. |
vladlos
force-pushed
the
fix-chart-tooltip-mixed-units
branch
from
3d1e666
to
ec5d109
Compare
|
@nathanstilwell added unit tests for my code |
nathanstilwell
approved these changes
Sep 24, 2019
We already calculate biggest scale for chart axis label, so I take that and cast values in chart tooltips to fit chart scale. So tooltips will show consistent units, matching the biggest unit type in data set and axis label. And also has 2 numbers after dot for better readability. This was done for duration and bytes units. Resolves: cockroachdb#35467 Release note (ui): consistent units in chart tooltips
nathanstilwell
force-pushed
the
fix-chart-tooltip-mixed-units
branch
from
ec5d109
to
1521b62
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 29, 2019
40970: ui: fix mixed units in tooltips r=nathanstilwell a=elkmaster We already calculate biggest scale for chart axis label, so I take that and cast values in chart tooltips to fit chart scale. So tooltips will show consistent units, matching the biggest unit type in data set and axis label. And also has 2 numbers after dot for better readability. This was done for duration and bytes units. Resolves: #35467 Release note (ui): consistent units in chart tooltips result:  41724: coldata: use flat bytes implementation instead of [][]byte r=yuzefovich a=yuzefovich **coldata: use flat bytes implementation instead of [][]byte** This commit reverts the revert of using []byte + offsets implementation of two-dimensional byte slice. The original revert was done due to several issues which will be addressed in the follow-up commits. **coldata: fix a couple of issues with flat bytes implementation** This commit fixes the following: - Slice method no longer modifies the receiver in-place and returns a shallow copy instead (as regular slices do) - in CopySlice, srcEndIdx has been updated to be "trimmed" so that offsets and lengths are not overwritten past the copied values. **coldata: remove lengths slice from flat bytes implementation** Previously, we would use offsets and lengths to store the information about each of the []byte in the flat bytes. However, that information was quite redundant since b.lengths[i] = b.offsets[i+1] - b.offsets[i], and this commit removes that redundancy. Also, this commit fixes a problem with how NULLs are treated. Previously, it was possible for offsets of flat bytes to get into an "inconsistent" state - we assume that the offsets are non-decreasing, but when a NULL value is set on the colexec.Vec, then Bytes will not be notified of this. As a result, there were "gaps" of unset zero values in offsets. Now we're actively backfilling the offsets to maintain the invariant. Fixes: #40244. **colexec: add invariants checker during logic tests** This commit adds an ability to plan vectorized invariants checkers while running the logic tests (in all configs except for when the vectorized engine is disabled). The only invariants that are currently being checked are that the batches are of correct width and that all byte slices (up to the length of the batch) can be retrieved from the flat bytes implementation. Release note: None 41926: sql: don't look up FK metadata when not checking FKs r=RaduBerinde a=RaduBerinde The `fkTables` argument to `MakeInserter` is only used when we are checking FKs; don't generate it when skipping the old path. Release note: None 41975: add otan to AUTHORS file r=otan a=otan Co-authored-by: Vlad <carrott9@gmail.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: Radu Berinde <radu@cockroachlabs.com> Co-authored-by: Oliver Tan <otan@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already calculate biggest scale for chart axis label, so I take that and cast values in chart tooltips to fit chart scale. So tooltips will show consistent units, matching the biggest unit type in data set and axis label. And also has 2 numbers after dot for better readability. This was done for duration and bytes units.
Resolves: #35467
Release note (ui): consistent units in chart tooltips
result:
