Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix sub-second EXTRACT behaves differently from postgres #41069

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@hueypark
Copy link
Contributor

hueypark commented Sep 25, 2019

Fixes #40683

Release note (sql change): sub-second EXTRACT behaves same as postgres.

Release justification: low-risk bugfix.

Release note (sql change): sub-second EXTRACT behaves same as postgres.

Release justification: low-risk bugfix.
@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Sep 25, 2019

This change is Reviewable

@jordanlewis jordanlewis requested a review from mjibson Sep 25, 2019
Copy link
Member

mjibson left a comment

Code LGTM. @jordanlewis will make a decision about whether we will ship this in 19.2

@knz

This comment has been minimized.

Copy link
Member

knz commented Sep 25, 2019

IMHO this is a bug fix, not "sql change", and is even candidate to back port in 19.1.

@mjibson

This comment has been minimized.

Copy link
Member

mjibson commented Sep 25, 2019

It's a bug fix only in that we differ from the spec: it was acting exactly as we intended otherwise. Anyone relying on EXTRACT will see a massive behavior change that will break their app. For that reason I think we should definitely not backport it to 19.1. 19.2 is a possibility because we haven't shipped that yet and so we allow some behavior changes. I'm still lightly on the "it should wait for 20.1" side myself.

@mjibson

This comment has been minimized.

Copy link
Member

mjibson commented Sep 25, 2019

As another example, our int / int operator differs from postgres. If we changed that today to exactly match postgres it seems unlikely we would backport that to 19.1, and it's even weird to consider shipping that in 19.2 at this point in the release cycle.

@mjibson

This comment has been minimized.

Copy link
Member

mjibson commented Sep 25, 2019

We've decided to wait for 20.1 to ship this. I'll merge this as soon as the master branch is open, which we expect to be in a week.

@hueypark

This comment has been minimized.

Copy link
Contributor Author

hueypark commented Sep 26, 2019

Thanks for the careful review!

@mjibson

This comment has been minimized.

Copy link
Member

mjibson commented Oct 8, 2019

bors r+

craig bot pushed a commit that referenced this pull request Oct 8, 2019
41069: sql: fix sub-second EXTRACT behaves differently from postgres r=mjibson a=hueypark

Fixes #40683

Release note (sql change): sub-second EXTRACT behaves same as postgres.

Release justification: low-risk bugfix.

Co-authored-by: Jaewan Park <jaewan.huey.park@gmail.com>
@craig

This comment has been minimized.

Copy link

craig bot commented Oct 8, 2019

Build succeeded

@craig craig bot merged commit 45dc856 into cockroachdb:master Oct 8, 2019
3 checks passed
3 checks passed
GitHub CI (Cockroach) TeamCity build finished
Details
bors Build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.