movr: Initialize movr's faker if it hasn't been already in workload #41072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
danhhz
approved these changes
Sep 25, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @danhhz and @rohany)
pkg/workload/movr/movr.go, line 566 at r1 (raw file):
// Initialize the faker in case it hasn't been setup already. g.fakerOnce.Do(func() {
nit: can you move this earlier? It's a little odd that it's after getRandomUser but before all the other ones. i'd actually put it first thing to mirror the one in Tables
Fixes cockroachdb#40846. Release justification: Low risk bug fix. Release note (bug fix): Fix panic in cockroach workload movr run.
rohany
force-pushed
the
movr-workload-fix
branch
from
e4eac06
to
df82e4e
Compare
|
bors r=danhhz |
craig bot
pushed a commit
that referenced
this pull request
Sep 25, 2019
40999: colexec: miscellaneous cleanups r=jordanlewis a=yuzefovich This commit cleans up a few things: - removes Int8 and Float32 methods from Vec interface (these types were recently removed) - removes special casing for CFetcher when catching a vectorized panic (CFetcher has been recently moved into colexec package) - adds leaktest to all tests in colexec package. Release justification: Category 1: Non-production code changes. Release note: None 41072: movr: Initialize movr's faker if it hasn't been already in workload r=danhhz a=rohany Fixes #40846. Release justification: Low risk bug fix. Release note (bug fix): Fix panic in cockroach workload movr run. Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: Rohan Yadav <rohany@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40846.
Release justification: Low risk bug fix.
Release note (bug fix): Fix panic in cockroach workload movr run.