release-19.1: cli: ensure SQL commands work when defaultdb d…
#41131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
bdarnell
approved these changes
Sep 26, 2019
All the various CLI commands that establish a SQL connection require the target database to exist. If no database is specified via `--database` or `--url`, the server automatically defaults to `defaultdb`. Prior to this patch, the CLI commands that do not strictly require a user database to function properly would fail if `defaultdb` did not exist (e.g. because a user chooses to drop it). This patch changes them to adopt the `system` database instead. The two commands that are operate on a user database, namely `cockroach sql` and `cockroach dump`, continue to work as prior. Release justification: fixes a bug Release note (bug fix): `cockroach zip`, `cockroach node` and `cockroach user` now work properly if the `defaultdb` database has been manually dropped and the connection URL does not specify a database. (Note that `cockroach user` is deprecated in 19.2).
knz
force-pushed
the
backport19.1-41121
branch
from
5b17c46
to
cec56a6
Compare
knz
changed the title
defaultdb does not existdefaultdb d…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #41121.
/cc @cockroachdb/release
Fixes #40967.
Release justification: fixes a bug
Release note (bug fix):
cockroach zip,cockroach nodeandcockroach usernow work properly if thedefaultdbdatabase hasbeen manually dropped and the connection URL does not specify a
database.