Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-19.1: libroach: initialize range tombstone counter #41301

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

ajkr
Copy link
Contributor

@ajkr ajkr commented Oct 3, 2019

Backport 1/1 commits from #41244.

/cc @cockroachdb/release


We forgot to initialize a variable that is used to decide whether a
compaction output file should be marked to undergo another compaction.

Release note (bug fix): reduce write-amp by avoiding forcing files
through compactions unnecessarily.

@ajkr ajkr requested a review from a team October 3, 2019 19:32
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

We forgot to initialize a variable that is used to decide whether a
compaction output file should be marked to undergo another compaction.

Release note (bug fix): reduce write-amp by avoiding forcing files
through compactions unnecessarily.
@ajkr ajkr merged commit 948a00e into cockroachdb:release-19.1 Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants