Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1 backport] rocksdb: Include fix on improving SST IDs used in cache keys #41394

Merged

Conversation

itsbilal
Copy link
Member

@itsbilal itsbilal commented Oct 7, 2019

Bumps up commit of RocksDB fork to pick up
cockroachdb/rocksdb#63 . This should resolve
some issues observed around out-of-order insertion of keys in SSTables.

Release note (bug fix): Fix a rare data corruption bug in RocksDB
caused by newer Linux kernel's handling of i_generation on certain
filesystems

Bumps up commit of RocksDB fork to pick up
cockroachdb/rocksdb#63 . This should resolve
some issues observed around out-of-order insertion of keys in SSTables.

Release note (bug fix): Fix a rare data corruption bug in RocksDB
caused by newer Linux kernel's handling of i_generation on certain
filesystems
@itsbilal itsbilal requested review from ajkr, petermattis and a team October 7, 2019 18:27
@itsbilal itsbilal self-assigned this Oct 7, 2019
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@itsbilal itsbilal changed the title rocksdb: Include fix on improving SST IDs used in cache keys [2.1 backport] rocksdb: Include fix on improving SST IDs used in cache keys Oct 7, 2019
Copy link
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsbilal itsbilal merged commit 51957cb into cockroachdb:release-2.1 Oct 8, 2019
@garvitjuniwal
Copy link
Contributor

thanks for the fix @itsbilal and @petermattis

does this bug also affect release-2.0? i'm wondering if a backport to 2.0 is also necessary or not.

@petermattis
Copy link
Collaborator

@garvitjuniwal Yes, I believe this bug affects all versions of RocksDB, so 2.0 as well. @itsbilal Can you backport to 2.0? @garvitjuniwal We're not currently making new 2.0 releases, but I believe that is ok in your case, correct?

@garvitjuniwal
Copy link
Contributor

Yes @petermattis. We can merge your 2.0 backport into our internal branch and use it. We don't need a new release. Thank you!

@itsbilal
Copy link
Member Author

@garvitjuniwal 2.0 backport is in progress: cockroachdb/rocksdb#65

Once this is in, I'll push a commit to update the rocksdb ref in release-2.0 in the cockroach repo to point to the patched version. You should then be able to merge that in.

@garvitjuniwal
Copy link
Contributor

Thanks @itsbilal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants