sql/sem/builtins: support more time spans for EXTRACT and DATE_TRUNC #41784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PostgreSQL supports millennium, century, decade, isoyear, isodow, and julian as field name in EXTRACT function. PostgreSQL supports millennium, century, and decade as field name in DATE_TRUNC function. This patch adds supports of those elements to EXTRACT and DATE_TRUNC. Issue: cockroachdb#41548 Release note (sql change): EXTRACT now supports millennium, century, decade, isoyear, isodow, and julian for date, timestamp, and timestamptz. DATE_TRUNC now supports millennium, century, and decade for date, timestamp, and timestamptz.
|
This change is |
|
Guessing maybe @mjibson is a good reviewer? |
maddyblue
approved these changes
Oct 21, 2019
|
bors r+ |
Build failed |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 21, 2019
41784: sql/sem/builtins: support more time spans for EXTRACT and DATE_TRUNC r=mjibson a=rogaps PostgreSQL supports millennium, century, decade, isoyear, isodow, and julian as field name in EXTRACT function. PostgreSQL supports millennium, century, and decade as field name in DATE_TRUNC function. This patch adds supports of those elements to EXTRACT and DATE_TRUNC. Issue: #41548 Release note (sql change): EXTRACT now supports millennium, century, decade, isoyear, isodow, and julian for date, timestamp, and timestamptz. DATE_TRUNC now supports millennium, century, and decade for date, timestamp, and timestamptz. Co-authored-by: Roga Pria Sembada <rogaps@gmail.com>
Build succeeded |
This was referenced Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgreSQL supports millennium, century, decade, isoyear, isodow, and
julian as field name in EXTRACT function. PostgreSQL supports
millennium, century, and decade as field name in DATE_TRUNC function.
This patch adds supports of those elements to EXTRACT and DATE_TRUNC.
Issue: #41548
Release note (sql change): EXTRACT now supports millennium, century,
decade, isoyear, isodow, and julian for date, timestamp, and timestamptz.
DATE_TRUNC now supports millennium, century, and decade for date,
timestamp, and timestamptz.