sql: no longer require CASCADE for dropping a unique index created explicitly #42001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
changed the title
yuzefovich
force-pushed
the
drop-unique-index
branch
from
7a3db64
to
1f910e3
Compare
maddyblue
approved these changes
Oct 29, 2019
…plicitly Previously, all unique indexes needed 'CASCADE' to be dropped, regardless of the way they were created. However, if the index is created "explicitly" (i.e. via 'CREATE UNIQUE INDEX' statement), we should be able to drop it without 'CASCADE'. This is what Postgres does. Now this is we do as well. Release note (sql change): dropping a unique index that was created via 'CREATE UNIQUE INDEX' statement no longer requires 'CASCADE' option.
yuzefovich
force-pushed
the
drop-unique-index
branch
from
1f910e3
to
1c4be57
Compare
|
TFTR! bors r+ |
|
bors r- |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 30, 2019
42001: sql: no longer require CASCADE for dropping a unique index created explicitly r=yuzefovich a=yuzefovich Previously, all unique indexes needed 'CASCADE' to be dropped, regardless of the way they were created. However, if the index is created "explicitly" (i.e. via 'CREATE UNIQUE INDEX' statement), we should be able to drop it without 'CASCADE'. This is what Postgres does. Now this is we do as well. Release note (sql change): dropping a unique index that was created via 'CREATE UNIQUE INDEX' statement no longer requires 'CASCADE' option. Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all unique indexes needed 'CASCADE' to be dropped,
regardless of the way they were created. However, if the index is
created "explicitly" (i.e. via 'CREATE UNIQUE INDEX' statement),
we should be able to drop it without 'CASCADE'. This is what
Postgres does. Now this is we do as well.
Release note (sql change): dropping a unique index that was created
via 'CREATE UNIQUE INDEX' statement no longer requires 'CASCADE'
option.