movr: update workload to use random values in columns rather than NULL #42483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original pass at the movr workload filled up the non-indexed columns with null values rather than using randomly generated values. This PR fixes that. Fixes cockroachdb#42435. Release note (bug fix): The movr workload now populates table columns with randomly generated data instead of NULLs.
|
This change is |
danhhz
approved these changes
Nov 14, 2019
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 14, 2019
42483: movr: update workload to use random values in columns rather than NULL r=rohany a=rohany The original pass at the movr workload filled up the non-indexed columns with null values rather than using randomly generated values. This PR fixes that. Fixes #42435. Release note (bug fix): The movr workload now populates table columns with randomly generated data instead of NULLs. Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original pass at the movr workload filled up the non-indexed columns with
null values rather than using randomly generated values. This PR fixes that.
Fixes #42435.
Release note (bug fix): The movr workload now populates table columns with randomly
generated data instead of NULLs.