-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: fix make buildshort
#42541
Merged
Merged
build: fix make buildshort
#42541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `make buildshort` was failing to include a couple of CCL package, resulting in a build unable to enable enterprise features. This patch fixes it. Release note (build change): `make buildshort` is now able to produce valid CCL binaries with all enterprise features (minus UI).
cc @RaduBerinde that would be why your |
tbg
approved these changes
Nov 18, 2019
tfyr! bors r+ |
Build failed (retrying...) |
craig bot
pushed a commit
that referenced
this pull request
Nov 18, 2019
42541: build: fix `make buildshort` r=knz a=knz Previously, `make buildshort` was failing to include a couple of CCL package, resulting in a build unable to enable enterprise features. This patch fixes it. Release note (build change): `make buildshort` is now able to produce valid CCL binaries with all enterprise features (minus UI). Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
Build failed |
transient agent failure, trying again bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 18, 2019
42501: cmd/reduce: only walk window frames if present r=mjibson a=mjibson Release note: None 42541: build: fix `make buildshort` r=knz a=knz Previously, `make buildshort` was failing to include a couple of CCL package, resulting in a build unable to enable enterprise features. This patch fixes it. Release note (build change): `make buildshort` is now able to produce valid CCL binaries with all enterprise features (minus UI). Co-authored-by: Matt Jibson <matt.jibson@gmail.com> Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
make buildshort
was failing to include a couple of CCLpackage, resulting in a build unable to enable enterprise features.
This patch fixes it.
Release note (build change):
make buildshort
is now able to producevalid CCL binaries with all enterprise features (minus UI).