Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix make buildshort #42541

Merged
merged 1 commit into from
Nov 18, 2019
Merged

build: fix make buildshort #42541

merged 1 commit into from
Nov 18, 2019

Conversation

knz
Copy link
Contributor

@knz knz commented Nov 18, 2019

Previously, make buildshort was failing to include a couple of CCL
package, resulting in a build unable to enable enterprise features.

This patch fixes it.

Release note (build change): make buildshort is now able to produce
valid CCL binaries with all enterprise features (minus UI).

Previously, `make buildshort` was failing to include a couple of CCL
package, resulting in a build unable to enable enterprise features.

This patch fixes it.

Release note (build change): `make buildshort` is now able to produce
valid CCL binaries with all enterprise features (minus UI).
@knz knz requested a review from tbg November 18, 2019 16:57
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz
Copy link
Contributor Author

knz commented Nov 18, 2019

cc @RaduBerinde that would be why your cockroach demo was not fully operational. I just ran into the same.

@knz
Copy link
Contributor Author

knz commented Nov 18, 2019

tfyr!

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 18, 2019

Build failed (retrying...)

craig bot pushed a commit that referenced this pull request Nov 18, 2019
42541: build: fix `make buildshort` r=knz a=knz

Previously, `make buildshort` was failing to include a couple of CCL
package, resulting in a build unable to enable enterprise features.

This patch fixes it.

Release note (build change): `make buildshort` is now able to produce
valid CCL binaries with all enterprise features (minus UI).

Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
@craig
Copy link
Contributor

craig bot commented Nov 18, 2019

Build failed

@knz
Copy link
Contributor Author

knz commented Nov 18, 2019

transient agent failure, trying again

bors r+

craig bot pushed a commit that referenced this pull request Nov 18, 2019
42501: cmd/reduce: only walk window frames if present r=mjibson a=mjibson

Release note: None

42541: build: fix `make buildshort` r=knz a=knz

Previously, `make buildshort` was failing to include a couple of CCL
package, resulting in a build unable to enable enterprise features.

This patch fixes it.

Release note (build change): `make buildshort` is now able to produce
valid CCL binaries with all enterprise features (minus UI).

Co-authored-by: Matt Jibson <matt.jibson@gmail.com>
Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
@craig
Copy link
Contributor

craig bot commented Nov 18, 2019

Build succeeded

@craig craig bot merged commit 8e2df31 into cockroachdb:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants