sql: add CREATE SCHEMA IF NOT EXISTS for existing schemas #42703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Nice! Glad we have this to round out the set.
…On Fri, Nov 22, 2019 at 1:16 PM cockroach-teamcity ***@***.***> wrote:
This change is [image: Reviewable]
<https://reviewable.io/reviews/cockroachdb/cockroach/42703>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#42703?email_source=notifications&email_token=AFJ7F72D3PK44UHDPSJPX3LQVAOW7A5CNFSM4JQUIDJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE6NYWY#issuecomment-557636699>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFJ7F753XWCIMEDVDX5HVUDQVAOW7ANCNFSM4JQUIDJQ>
.
--
Andy Woods
Product Manager, Cockroach Labs
andy@cockroachlabs.com
|
rafiss
approved these changes
Nov 27, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @arulajmani, @jordanlewis, and @rafiss)
pkg/sql/create_schema.go, line 27 at r1 (raw file):
if !n.n.IfNotExists { return unimplemented.NewWithIssuef(26443, "new schemas are unsupported")
i guess it would be potentially more accurate for the error to say "schema already exists" or something if one does CREATE SCHEMA [public|pg_catalog|crdb_internal]
but it doesn't seem super important, so fine with merging,
|
|
This helps compatibility a bit. Release note (sql change): allow no-op CREATE SCHEMA IF NOT EXISTS statements. Release justification: low-risk, high benefit changes to existing functionality (compatibility improvement with no new functionality)
ajwerner
approved these changes
Mar 11, 2020
There was a problem hiding this comment.
Reviewed 12 of 12 files at r2.
Reviewable status:
|
bors r+ |
Build failed |
|
Javascript heap OOM? bors r+ |
Build succeeded |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps compatibility a bit.
Release note (sql change): allow no-op CREATE SCHEMA IF NOT EXISTS
statements.
Release justification: low-risk, high benefit changes to existing
functionality (compatibility improvement with no new functionality)