Allow implicit casting to int[], decimal[] #42704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rafiss
requested changes
Nov 22, 2019
There was a problem hiding this comment.
minor nit: typo in commit message for strign
other than very small comments, looks great! thanks
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @apantel and @rafiss)
pkg/sql/sem/tree/constant_test.go, line 269 at r1 (raw file):
types.Interval: mustParseDInterval, types.Jsonb: mustParseDJSON, types.IntArray: mustParseDIntArray,
can a test also be added for DecimalArray?
apantel
commented
Nov 22, 2019
There was a problem hiding this comment.
Reviewable status:
pkg/sql/sem/tree/constant_test.go, line 269 at r1 (raw file):
Previously, rafiss (Rafi Shamim) wrote…
can a test also be added for DecimalArray?
Done.
apantel
force-pushed
the
upcast
branch
5 times, most recently
from
2df56a7
to
cf31cdf
Compare
apantel
commented
Nov 26, 2019
There was a problem hiding this comment.
Dismissed @rafiss from a discussion.
Reviewable status:
|
bors r+ |
Build failed |
Fixes cockroachdb#41405 Release note (sql change): Cast string to int[] or decimal[] when appropriate
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 26, 2019
42601: storage/protectedts: introduce interfaces r=nvanbenschoten a=ajwerner This commit introduces the interfaces for the protectedts subsystem. The APIs are centered around protobufs for no great reason; it's mostly an implementation vestige. I'm happy to swap it out for regular go structs. That being said, there is something nice about having a well-defined encoding for values. This is the first of a number of PRs to come from #42600. Release note: None 42704: Allow implicit casting to int[], decimal[] r=apantel a=apantel Fixes #41405 Release note (sql change): Cast string to int[] or decimal[] when appropriate 42782: Correct some columns in pg_type from OID to REGPROC. r=apantel a=apantel Fixes #42568 Release note (sql change): Some columns (typinput, typoutput, typreceive, typsend, typmodin, typmodout, typanalyze) in pg_type were incorrectly typed as OID instead of REGPROC. 42785: gceworker: fix substitution error r=RaduBerinde a=RaduBerinde Some folks have been getting `${response,,}: bad substitution` errors, I guess because their version of bash doesn't understand it. Changing to a POSIX standard way to convert to lowercase. Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com> Co-authored-by: Adam Pantel <adam@cockroachlabs.com> Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41405
Release note (sql change): Cast string to int[] or decimal[] when appropriate