Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: fix broken kerberos build in linux #42768

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Makefile: fix broken kerberos build in linux #42768

wants to merge 1 commit into from

Conversation

badis
Copy link

@badis badis commented Nov 26, 2019

Possibly related to issues: #38841 and #39480.
I have enabled building of shared libraries for kerberos in linux(ubuntu 18.04) to avoid this kind of errors:

/home/badis/go/src/github.com/cockroachdb/cockroach/c-deps/krb5/src/lib/crypto/builtin/aes/iaesx64.s:791: Error: junk at end of line, first unrecognized character is `%'
/home/badis/go/src/github.com/cockroachdb/cockroach/c-deps/krb5/src/lib/crypto/builtin/aes/iaesx64.s:792: Error: no such instruction: `section .note.GNU-stack noalloc noexec nowrite progbits'
/home/badis/go/src/github.com/cockroachdb/cockroach/c-deps/krb5/src/lib/crypto/builtin/aes/iaesx64.s:793: Error: junk at end of line, first unrecognized character is `%'
/home/badis/go/src/github.com/cockroachdb/cockroach/c-deps/krb5/src/lib/crypto/builtin/aes/iaesx64.s:794: Error: junk at end of line, first unrecognized character is `%'
/home/badis/go/src/github.com/cockroachdb/cockroach/c-deps/krb5/src/lib/crypto/builtin/aes/iaesx64.s:795: Error: no such instruction: `section .note.GNU-stack noalloc noexec nowrite progbits'
/home/badis/go/src/github.com/cockroachdb/cockroach/c-deps/krb5/src/lib/crypto/builtin/aes/iaesx64.s:796: Error: junk at end of line, first unrecognized character is `%'
/home/badis/go/src/github.com/cockroachdb/cockroach/c-deps/krb5/src/lib/crypto/builtin/aes/iaesx64.s:797: Error: junk at end of line, first unrecognized character is `%'
/home/badis/go/src/github.com/cockroachdb/cockroach/c-deps/krb5/src/lib/crypto/builtin/aes/iaesx64.s:798: Error: no such instruction: `section .note.GNU-stack noalloc noexec nowrite progbits'
/home/badis/go/src/github.com/cockroachdb/cockroach/c-deps/krb5/src/lib/crypto/builtin/aes/iaesx64.s:799: Error: junk at end of line, first unrecognized character is `%'
<builtin>: recipe for target 'iaesx64.o' failed
make[5]: *** [iaesx64.o] Error 1
Makefile:1139: recipe for target 'all-recurse' failed
make[4]: *** [all-recurse] Error 1
Makefile:1107: recipe for target 'all-recurse' failed
make[3]: *** [all-recurse] Error 1
Makefile:992: recipe for target 'all-recurse' failed
make[2]: *** [all-recurse] Error 1
Makefile:1533: recipe for target 'all-recurse' failed
make[1]: *** [all-recurse] Error 1
Makefile:719: recipe for target '/home/badis/go/native/x86_64-linux-gnu/krb5/lib/libgssapi_krb5.a' failed
make: *** [/home/badis/go/native/x86_64-linux-gnu/krb5/lib/libgssapi_krb5.a] Error 2

Release note (bug fix): Fixed a Makefile bug that would prevent building shared libraries of kerberos in linux and thus prevent building CockroachDB from sources.

I think it's related to issues:  #38841 and #39480.
I have enabled building of shared libraries for kerberos in Makefile line 595 to avoid this kind of errors:

```
/home/badis/go/src/github.com/cockroachdb/cockroach/c-deps/krb5/src/lib/crypto/builtin/aes/iaesx64.s:791: Error: junk at end of line, first unrecognized character is `%'
/home/badis/go/src/github.com/cockroachdb/cockroach/c-deps/krb5/src/lib/crypto/builtin/aes/iaesx64.s:792: Error: no such instruction: `section .note.GNU-stack noalloc noexec nowrite progbits'
/home/badis/go/src/github.com/cockroachdb/cockroach/c-deps/krb5/src/lib/crypto/builtin/aes/iaesx64.s:793: Error: junk at end of line, first unrecognized character is `%'
/home/badis/go/src/github.com/cockroachdb/cockroach/c-deps/krb5/src/lib/crypto/builtin/aes/iaesx64.s:794: Error: junk at end of line, first unrecognized character is `%'
/home/badis/go/src/github.com/cockroachdb/cockroach/c-deps/krb5/src/lib/crypto/builtin/aes/iaesx64.s:795: Error: no such instruction: `section .note.GNU-stack noalloc noexec nowrite progbits'
/home/badis/go/src/github.com/cockroachdb/cockroach/c-deps/krb5/src/lib/crypto/builtin/aes/iaesx64.s:796: Error: junk at end of line, first unrecognized character is `%'
/home/badis/go/src/github.com/cockroachdb/cockroach/c-deps/krb5/src/lib/crypto/builtin/aes/iaesx64.s:797: Error: junk at end of line, first unrecognized character is `%'
/home/badis/go/src/github.com/cockroachdb/cockroach/c-deps/krb5/src/lib/crypto/builtin/aes/iaesx64.s:798: Error: no such instruction: `section .note.GNU-stack noalloc noexec nowrite progbits'
/home/badis/go/src/github.com/cockroachdb/cockroach/c-deps/krb5/src/lib/crypto/builtin/aes/iaesx64.s:799: Error: junk at end of line, first unrecognized character is `%'
<builtin>: recipe for target 'iaesx64.o' failed
make[5]: *** [iaesx64.o] Error 1
Makefile:1139: recipe for target 'all-recurse' failed
make[4]: *** [all-recurse] Error 1
Makefile:1107: recipe for target 'all-recurse' failed
make[3]: *** [all-recurse] Error 1
Makefile:992: recipe for target 'all-recurse' failed
make[2]: *** [all-recurse] Error 1
Makefile:1533: recipe for target 'all-recurse' failed
make[1]: *** [all-recurse] Error 1
Makefile:719: recipe for target '/home/badis/go/native/x86_64-linux-gnu/krb5/lib/libgssapi_krb5.a' failed
make: *** [/home/badis/go/native/x86_64-linux-gnu/krb5/lib/libgssapi_krb5.a] Error 2

```
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Nov 26, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Badis Merabet seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@badis badis changed the title Fix broken kerberos build for linux Makefile: fix broken kerberos build for on linux Nov 26, 2019
@badis badis changed the title Makefile: fix broken kerberos build for on linux Makefile: fix broken kerberos build for in linux Nov 26, 2019
@badis badis changed the title Makefile: fix broken kerberos build for in linux Makefile: fix broken kerberos build in linux Nov 26, 2019
@benesch
Copy link
Contributor

benesch commented Apr 28, 2020

This doesn't seem like the right way to fix the issue, I'm afraid. If it works for your use case, great! But the cockroach build system is meant to produce a completely statically linked binary (save for libc, if you're using a system that does not support statically linking libc). The fix which @knz proposes in #39480, of overriding the unworkable configure check, seems like the way to go.

@knz
Copy link
Contributor

knz commented Apr 29, 2020

@badis can you have a look at #48132 and see if something similar applies to you here?

@tbg tbg added the X-noremind Bots won't notify about PRs with X-noremind label May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
X-noremind Bots won't notify about PRs with X-noremind
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants