opt: fix assertion failure due to lax empty key #43722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rytaft
approved these changes
Jan 6, 2020
There was a problem hiding this comment.
[nit] the issue referenced in the commit/PR message (Fixes #43532) isn't an issue -- it's the original PR that created the issue. Is there an issue you meant to reference?
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @andy-kimball)
PR cockroachdb#43532 removed the concept of lax constant functional dependencies. There is a left-over case when we downgrade a key: if we had a strong empty key, the result is a lax empty key which is no longer a concept. This change fixes this by removing the key altogether in this case. Fixes cockroachdb#43651. Release note (bug fix): fixes "expected constant FD to be strict" internal error.
RaduBerinde
force-pushed
the
fix-downgrade-key
branch
from
c523f38
to
0af511c
Compare
|
Thanks, fixed the issue number. |
rytaft
approved these changes
Jan 6, 2020
There was a problem hiding this comment.
Reviewable status:
andy-kimball
approved these changes
Jan 6, 2020
There was a problem hiding this comment.
Reviewable status:
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jan 6, 2020
43703: storage/batcheval/result: perform various cleanup on LocalResult struct r=nvanbenschoten a=nvanbenschoten This PR contains a series of cleanups to the `result.LocalResult` struct. It leaves the structure in a good position to be extended to include information about newly written, updated, and removed intents, which are hooked into the `concurrency` package in future commits the same way that `UpdatedTxns` is currently hooked into the TxnWaitQueue. The changes are broken into a series of incremental steps to make them easier to review in isolation. 43722: opt: fix assertion failure due to lax empty key r=RaduBerinde a=RaduBerinde PR #43532 removed the concept of lax constant functional dependencies. There is a left-over case when we downgrade a key: if we had a strong empty key, the result is a lax empty key which is no longer a concept. This change fixes this by removing the key altogether in this case. Fixes #43651. Release note (bug fix): fixes "expected constant FD to be strict" internal error. 43734: pgwire: deflake TestAuthenticationAndHBARules r=knz a=knz Fixes #43733. This was my mistake to fix, I had forgotten that cluster settings propagate asynchronously. Release note: None Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com> Co-authored-by: Radu Berinde <radu@cockroachlabs.com> Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
Build succeeded |
This was referenced Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #43532 removed the concept of lax constant functional dependencies.
There is a left-over case when we downgrade a key: if we had a strong
empty key, the result is a lax empty key which is no longer a concept.
This change fixes this by removing the key altogether in this case.
Fixes #43651.
Release note (bug fix): fixes "expected constant FD to be strict"
internal error.