Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-19.1: pgwire/hba: fix a bug in the parsing logic #43812

Merged
merged 2 commits into from Jan 8, 2020

Conversation

@knz
Copy link
Member

knz commented Jan 8, 2020

Backport 2/2 commits from #43713.

/cc @cockroachdb/release


knz added 2 commits Jan 3, 2020
There is a bug in the code, however the HBA parsing test was unable to
see it. This patch changes the test to outline the bug ahead of fixing
it.

Release note: None
Release note (bug fix): There was a bug in the parsing logic for
server.host_based_authentication.configuration, where both
single-character strings, and quoted strings containing spaces and
separated by commas were not properly parsed. This would cause
e.g. rules for usernames consisting of a single characters, or
usernames containing spaces, to apply improperly.
@knz knz requested a review from mjibson Jan 8, 2020
@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Jan 8, 2020

This change is Reviewable

@mjibson
mjibson approved these changes Jan 8, 2020
@knz knz merged commit 3d6bb03 into cockroachdb:release-19.1 Jan 8, 2020
2 checks passed
2 checks passed
GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details
@knz knz deleted the knz:backport19.1-43714 branch Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.