Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colexec: fix an issue with builtin operators and a minor cleanup #43989

Merged
merged 1 commit into from
Jan 15, 2020

Commits on Jan 15, 2020

  1. colexec: fix an issue with builtin operators and a minor cleanup

    Flat bytes relies on coldata.Batch.SetLength call to maintain its
    invariant. We assume that it is always called before return the batch in
    which Bytes vector might have been modified. This was not the case for
    default builtin and substring operators, and the calls were added.
    Additionally, to be safe, similar calls have been in added in projection
    operators.
    
    In a few places where we were setting the length of an internal batch to
    0 and then returning it, those were replaced with returning
    coldata.ZeroBatch. This forced us to refactor CASE and AND/OR operators
    to handle cases of zero-length batches (previously, they assumed
    a well-typed zero-length batch which is not always the case).
    
    Release note: None
    yuzefovich committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    c83e4b6 View commit details
    Browse the repository at this point in the history