distsql: reduce log severity of inbound stream error #44020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbound streams may error out for normal reasons. One of these is when a context cancellation happens. Any error was logged at the ERROR level, that severity has now been reduced to INFO and the required verbosity to log has been increased to 2. Release note (bug fix): A benign error previously logged at the ERROR level is now logged at the INFO level behind a verbosity(2) flag. This error might have been observed as "context canceled: readerCtx in Inbox stream handler".
|
This change is |
|
Fixes #43953 |
yuzefovich
approved these changes
Jan 15, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
TFTR bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jan 15, 2020
44020: distsql: reduce log severity of inbound stream error r=asubiotto a=asubiotto Inbound streams may error out for normal reasons. One of these is when a context cancellation happens. Any error was logged at the ERROR level, that severity has now been reduced to INFO and the required verbosity to log has been increased to 2. Release note (bug fix): A benign error previously logged at the ERROR level is now logged at the INFO level behind a verbosity(2) flag. This error might have been observed as "context canceled: readerCtx in Inbox stream handler". Fixes #43953 Co-authored-by: Alfonso Subiotto Marques <alfonso@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inbound streams may error out for normal reasons. One of these is when a
context cancellation happens. Any error was logged at the ERROR level, that
severity has now been reduced to INFO and the required verbosity to log has
been increased to 2.
Release note (bug fix): A benign error previously logged at the ERROR level
is now logged at the INFO level behind a verbosity(2) flag. This error might
have been observed as "context canceled: readerCtx in Inbox stream handler".
Fixes #43953