build: upgrade to node 12 LTS #44024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
vilterp
approved these changes
Jan 15, 2020
dhartunian
force-pushed
the
44021-use-node-12
branch
2 times, most recently
from
fe2e5e1
to
f7dd586
Compare
bobvawter
approved these changes
Jan 22, 2020
build/README.md
Outdated
| * [ ] Adjust version in Docker image ([source](./builder/Dockerfile#L218)). | ||
| * [ ] Rebuild the Docker image and bump the version in builder.sh accordingly ([source](./builder.sh#L6)). | ||
| * [ ] Bump the default installed version of nodejs in bootstrap-debian.sh ([source](./bootstrap/bootstrap-debian.sh#L9)). | ||
| * [ ] Update the `builder.dockerImage` parameter in the TeamCity `Cockroach` project. |
There was a problem hiding this comment.
Please don't make a copy of the checklist, they might get out of sync. Please just add a link back to the relevant section.
In order to use the latest webpack version we need to upgrade the node version as well. This upgrades us to the current LTS version. Added some documentation on this in README which mirrors many of the steps for a go upgrade. Added a `.node-version` file to the root of the repo which helps with using the `nodenv` tool to manage locally installed nodes versions. * [X] Adjust version in Docker image ([source](./builder/Dockerfile#L218)). * [X] Rebuild the Docker image and bump the version in builder.sh accordingly ([source](./builder.sh#L6)). * [X] Bump the default installed version of nodejs in bootstrap-debian.sh ([source](./bootstrap/bootstrap-debian.sh#L9)). * [X] Update the `builder.dockerImage` parameter in the TeamCity `Cockroach` project. Closes: cockroachdb#44021 Release note (build change): CockroachDB UI is now built with node12
dhartunian
force-pushed
the
44021-use-node-12
branch
from
f7dd586
to
22a4ef7
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jan 22, 2020
44024: build: upgrade to node 12 LTS r=dhartunian a=dhartunian In order to use the latest webpack version we need to upgrade the node version as well. This upgrades us to the current LTS version. Added some documentation on this in README which mirrors many of the steps for a go upgrade. Added a `.node-version` file to the root of the repo which helps with using the `nodenv` tool to manage locally installed nodes versions. * [X] Adjust version in Docker image ([source](./builder/Dockerfile#L218)). * [X] Rebuild the Docker image and bump the version in builder.sh accordingly ([source](./builder.sh#L6)). * [X] Bump the default installed version of nodejs in bootstrap-debian.sh ([source](./bootstrap/bootstrap-debian.sh#L9)). * [x] Update the `builder.dockerImage` parameter in the TeamCity `Cockroach` project. Closes: #44021 Release note (build change): CockroachDB UI is now built with node12 44164: colexec: add bool_or/bool_and operators r=asubiotto a=Azhng This PR adds `bool_and` and `bool_or` builtin functions to vectorized engine. Closes #43560 Release note (sql_change): The vectorize engine now supports bool_and/bool_or builtin aggregation functions. 44184: colexec: minor cleanup r=yuzefovich a=yuzefovich **colexec: clean up ordinalityOp** This commit changes the planning of ordinalityOp to specify the output column index (previously, the column was simply appended on the first call to Next). This unifies ordinalityOp with all other operators. Also, in theory it is possible that different batches are returned by the input to ordinalityOp, and the later batches might not have the appended column, but I cannot reproduce it in practice (probably because ordinality processor is only planned in non-distributed fashion, and if several nodes stream data to it, the streams will have been merged somehow). Anyway, I think this change is beneficial. Release note: None **colexec: remove redundant unset of Nulls in cfetcher** Nulls are reset as part of ResetInternalBatch call below, so unsetting them explicitly is redundant and is now removed. Release note: None **colexec: clean up any_not_null_agg template** This commit removes explicit template language to align any_not_null_tmpl with others. Release note: None Co-authored-by: David Hartunian <davidh@cockroachlabs.com> Co-authored-by: Azhng <archer.xn@gmail.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use the latest webpack version we need
to upgrade the node version as well.
This upgrades us to the current LTS version.
Added some documentation on this in README which
mirrors many of the steps for a go upgrade.
Added a
.node-versionfile to the root of therepo which helps with using the
nodenvtool tomanage locally installed nodes versions.
builder.dockerImageparameter in the TeamCityCockroachproject.Closes: #44021
Release note (build change): CockroachDB UI is now built with node12