Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-19.2: cli: fix --url with sslmode omitted but othe… #44115

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

knz
Copy link
Contributor

@knz knz commented Jan 17, 2020

Backport 1/1 commits from #44113.

/cc @cockroachdb/release


Fixes #44088.

Release note (bug fix): CockroachDB now properly supports
using `--url` with query options (e.g. `application_name`) but
without specifying `sslmode`. The default of `sslmode=disable` is
assumed in that case.
@knz knz requested a review from andreimatei January 17, 2020 15:48
@knz knz requested a review from a team as a code owner January 17, 2020 15:48
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz added this to To do in DB Server & Security via automation Jan 17, 2020
@knz knz moved this from To do to Done 20.1 in DB Server & Security Jan 17, 2020
@knz
Copy link
Contributor Author

knz commented Jan 21, 2020

friendly ping

@knz
Copy link
Contributor Author

knz commented Jan 21, 2020

the parent #44113 has not been merged yet

@knz knz changed the title release-19.2: cli: fix --url with sslmode omitted but other options presents release-19.2: cli: fix --url with sslmode omitted but othe… Jan 21, 2020
@knz knz merged commit de0613b into cockroachdb:release-19.2 Jan 21, 2020
@knz knz deleted the backport19.2-44113 branch January 21, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants