opt: fix incorrect empty key for full outer join #44156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When joining two single-row expressions, the cross product has an empty key, but the outer join does not. We need to remove the key in this case. Fixes cockroachdb#44029. Release note (bug fix): fixed planning bug related to FULL joins between single-row relations.
|
This change is |
andy-kimball
approved these changes
Jan 21, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @andy-kimball)
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jan 22, 2020
44156: opt: fix incorrect empty key for full outer join r=RaduBerinde a=RaduBerinde When joining two single-row expressions, the cross product has an empty key, but the outer join does not. We need to remove the key in this case. Fixes #44029. Release note (bug fix): fixed planning bug related to FULL joins between single-row relations. Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When joining two single-row expressions, the cross product has an
empty key, but the outer join does not. We need to remove the key in
this case.
Fixes #44029.
Release note (bug fix): fixed planning bug related to FULL joins
between single-row relations.