Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1: server,sql: allow admin UI to view table details for non-admins #44194

Merged
merged 1 commit into from Jan 22, 2020

Conversation

@otan
Copy link
Collaborator

otan commented Jan 22, 2020

Backport 1/1 commits from #44167.

/cc @cockroachdb/release


Resolves #44033

  • Added crdb_internal.get_zone_config and
    crdb_internal.get_namespace_id, which executes queries to system
    tables and checks permissions afterwards. This is needed for speedy
    point lookups for the admin UI.
  • Modified the EvalContext with a PrivilegedAccessor, containing
    any accessors that requires privileged access to view data.
  • Modified the admin UI to use the new crdb_internal queries.

Release note (admin ui change, security update, bug fix): We previously
introduced a fix on the admin UI to prevent non-admin users from
executing queries - however, this accidentally made certain pages
requiring table details not to display. This PR allows the table details
to be displayed in its former glory.

* Added `crdb_internal.get_zone_config` and
`crdb_internal.get_namespace_id`, which executes queries to system
tables and checks permissions afterwards. This is needed for speedy
point lookups for the admin UI.
* Modified the EvalContext with a PrivilegedAccessor, containing
any accessors that requires privileged access to view data.
* Modified the admin UI to use the new crdb_internal queries.

Release note (admin ui change, security update, bug fix): We previously
introduced a fix on the admin UI to prevent non-admin users from
executing queries - however, this accidentally made certain pages
requiring table details not to display. This PR allows the table details
to be displayed in its former glory.
@otan otan requested a review from knz Jan 22, 2020
@cockroach-teamcity

This comment has been minimized.

Copy link
Member

cockroach-teamcity commented Jan 22, 2020

This change is Reviewable

@otan otan merged commit 0f056a5 into cockroachdb:release-2.1 Jan 22, 2020
3 checks passed
3 checks passed
Commit Message Lint Pull request title and commit message format are not configured
Details
GitHub CI (Cockroach) TeamCity build finished
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.