ui: Decommissioned node history page - fix follow up issues #44205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
koorosh
changed the title
|
@koorosh can you rebase on master so we can see with new sidebar? |
dhartunian
requested changes
Feb 4, 2020
| @@ -52,7 +52,11 @@ class DecommissionedNodeHistory extends React.Component<DecommissionedNodeHistor | |||
| { | |||
| key: "id", | |||
| title: "ID", | |||
| sorter: true, | |||
| sorter: (a, b) => { | |||
There was a problem hiding this comment.
Can you extract these sorter functions and give them names like sortByNodeID etc.
| }; | ||
|
|
||
| // DecommissionedNodeList displays 5 most recent nodes. | ||
| const data = _.chain(decommissionedStatuses) |
There was a problem hiding this comment.
Are we limiting to 5? I don't see that here.
- Updated design was reused to look the same as tables on Cluster Overview page - Pagination buttons are aligned by center - Added empty table state with proper message Release note (admin ui change): Decommissioned Node History view changed
Apply correct sorting comparator function for Node Id and Decommissioned on columns. Release note: None
koorosh
force-pushed
the
ui-decommissioned-node-history-page--fix-issues
branch
from
b48770c
to
9295a0f
Compare
…issioned Nodes table Release note: None
dhartunian
approved these changes
Feb 11, 2020
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Feb 11, 2020
44205: ui: Decommissioned node history page - fix follow up issues r=dhartunian a=koorosh Decommissioned Node History table has been redesigned according to the design system styles. - It doesn't use Sorted Table now, and was replaced by Table component. Fixes for: #43881 Co-authored-by: Andrii Vorobiov <and.vorobiov@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decommissioned Node History table has been redesigned according to the design system styles.
Fixes for: #43881