sql: add telemetry for uses of secondary indexes with column families #44506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
LGTM!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @otan and @rohany)
pkg/sql/sqltelemetry/schema.go, line 35 at r1 (raw file):
// SecondaryIndexColumnFamiliesCounter is a counter that is incremented every time // a secondary index that is separated into different column families is created. var SecondaryIndexColumnFamiliesCounter = telemetry.GetCounterOnce("sql.schema.secondary_index_column_families")
this looks like it'll conflict!
|
Conflict with what? Or just a merge conflict? |
Fixes cockroachdb#44375. Release note (sql change): This commit collects telemetry information for uses of secondary indexes that use column families.
rohany
force-pushed
the
sec-col-fam-tel
branch
from
3d942aa
to
6bd4439
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jan 30, 2020
44506: sql: add telemetry for uses of secondary indexes with column families r=rohany a=rohany Fixes #44375. Release note (sql change): This commit collects telemetry information for uses of secondary indexes that use column families. Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44375.
Release note (sql change): This commit collects telemetry information
for uses of secondary indexes that use column families.