opt: fix internal error when aggregating on a virtual table #44692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently introduced logic allows projecting any columns if we are grouping by the PK of the table. This code generates an internal error for virtual tables, which have no primary index. Note that in this case we expect an error. Fixes cockroachdb#44659. Release note (bug fix): fixed "no indexes" internal error in some cases when we GROUP BY on a virtual table.
|
This change is |
justinj
reviewed
Feb 4, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @rytaft)
rytaft
approved these changes
Feb 4, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:
|
bors r+ |
Build failed (retrying...) |
craig bot
pushed a commit
that referenced
this pull request
Feb 4, 2020
44692: opt: fix internal error when aggregating on a virtual table r=RaduBerinde a=RaduBerinde Recently introduced logic allows projecting any columns if we are grouping by the PK of the table. This code generates an internal error for virtual tables, which have no primary index. Note that in this case we expect an error. Fixes #44659. Release note (bug fix): fixed "no indexes" internal error in some cases when we GROUP BY on a virtual table. Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently introduced logic allows projecting any columns if we are
grouping by the PK of the table. This code generates an internal error
for virtual tables, which have no primary index. Note that in this
case we expect an error.
Fixes #44659.
Release note (bug fix): fixed "no indexes" internal error in some
cases when we GROUP BY on a virtual table.