colflow: error out when phys types mismatch when setting up a flow

[yuzefovich]

This commit adds a check that the physical types coming out of the last
columnar operator into the materializer are the same as the materializer
expects. This check is added to SupportsVectorized check, and in case of
types mismatch, we will fallback to the row-by-row engine.

The underlying cause for this particular reproduction is that our
"logical" types system assumes that ints have width 8, which is not
always the case. But trying to fix it is beyond the scope of this PR.

Fixes: #44904.

Release note (bug fix): Previously, CockroachDB could return an internal
error on the queries that return INT columns when the default int size
has been changed, and now this has been fixed.

[cockroach-teamcity]

This change is 

[yuzefovich]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @asubiotto)

---

pkg/sql/distsql_running.go, line 176 at r1 (raw file):

						},
						NodeID: -1,
					}, spec.Processors, fuseOpt, recv,

I wonder whether we should be on the safe side and pass it a copy of recv?

[asubiotto]

minus a nit about how the conditional is formulated

Reviewed 5 of 6 files at r1, 1 of 1 files at r2.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

---

pkg/sql/distsql_running.go, line 176 at r1 (raw file):

Previously, yuzefovich wrote…

I wonder whether we should be on the safe side and pass it a copy of recv?

I think it's fine.

---

pkg/sql/colflow/vectorized_flow.go, line 939 at r2 (raw file):

) (leaves []execinfra.OpNode, err error) {
	var syncFlowConsumer execinfra.RowReceiver
	if output != nil {

if output == nil {
    output = &execinfra.RowChannel{}
}

And then use output instead of syncFlowConsumer

[yuzefovich]

TFTR!

bors r+

Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @asubiotto)

---

pkg/sql/distsql_running.go, line 176 at r1 (raw file):

Previously, asubiotto (Alfonso Subiotto Marqués) wrote…

I think it's fine.

Ok, sgtm.

---

pkg/sql/colflow/vectorized_flow.go, line 939 at r2 (raw file):

Previously, asubiotto (Alfonso Subiotto Marqués) wrote…

if output == nil {
    output = &execinfra.RowChannel{}
}

And then use output instead of syncFlowConsumer

Good point, done.

[craig]

Build succeeded

• GitHub CI (Cockroach)