backup,import: count system table rows as rows #44965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
force-pushed
the
system-rows
branch
2 times, most recently
from
c1dc5bf
to
378ba4e
Compare
Previously we counted any KVs belonging to non-user tables as 'system records' rather than as 'rows' or 'index entries' the way they are counted for regular tables. This however meant that BACKUP or RESTORE would confusingly say that it had backed up 0 rows from a given system table when it in fact backed up its rows normally, unless one separately looked at the 'system record' count. Even if one does so, that is also confusing since it doesn't distinguish rows from index entries so the count does not match. Given that these counts are rolled up by table anyway the distinction gains us little. Release note (enterprise change): rows counts in BACKUP and RESTORE now include rows in system tables.
pbardea
reviewed
Feb 12, 2020
There was a problem hiding this comment.
LGTM, sorry for the delay!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @pbardea)
pbardea
approved these changes
Feb 12, 2020
|
TFTR! bors r+ |
Build failed (retrying...) |
craig bot
pushed a commit
that referenced
this pull request
Feb 12, 2020
44965: backup,import: count system table rows as rows r=dt a=dt Previously we counted any KVs belonging to non-user tables as 'system records' rather than as 'rows' or 'index entries' the way they are counted for regular tables. This however meant that BACKUP or RESTORE would confusingly say that it had backed up 0 rows from a given system table when it in fact backed up its rows normally, unless one separately looked at the 'system record' count. Even if one does so, that is also confusing since it doesn't distinguish rows from index entries so the count does not match. Given that these counts are rolled up by table anyway the distinction gains us little. Release note: none. 45010: storage/concurrency: move lock_table testdata to directory r=nvanbenschoten a=nvanbenschoten This creates room for new concurrency_manager testdata. There is a large diff, but it's just an outdent. We should probably get this in because #44975 so that we can put those new test cases in a new file. Co-authored-by: David Taylor <tinystatemachine@gmail.com> Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we counted any KVs belonging to non-user tables as 'system records'
rather than as 'rows' or 'index entries' the way they are counted for regular
tables. This however meant that BACKUP or RESTORE would confusingly say that
it had backed up 0 rows from a given system table when it in fact backed up
its rows normally, unless one separately looked at the 'system record' count.
Even if one does so, that is also confusing since it doesn't distinguish rows
from index entries so the count does not match. Given that these counts are
rolled up by table anyway the distinction gains us little.
Release note: none.