workload: fix non-uniqueness error in movr workload setup #45035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Fixes cockroachdb#44864. The generator for the promo codes table relied on a random word generator for the string primary key of the table. At a large enough row count this was nearly gauranteed to have a collision. This PR fixes it by prepending a unique rowid to each random promo code. Release note (cli change): This PR fixes a potential error occurring when loading the movr dataset with a large number of rows in the promo codes column.
rohany
force-pushed
the
demo-start-error
branch
from
032102e
to
15e859b
Compare
|
bors r+ |
Build failed |
|
trying bors again, not sure what went wrong. bors r+ |
Build failed |
|
bors r+ |
Build failed |
|
That was definitely a flake bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Feb 14, 2020
45035: workload: fix non-uniqueness error in movr workload setup r=rohany a=rohany Fixes #44864. The generator for the promo codes table relied on a random word generator for the string primary key of the table. At a large enough row count this was nearly gauranteed to have a collision. This PR fixes it by prepending a unique rowid to each random promo code. Release note (cli change): This PR fixes a potential error occurring when loading the movr dataset with a large number of rows in the promo codes column. Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44864.
The generator for the promo codes table relied on a random
word generator for the string primary key of the table.
At a large enough row count this was nearly gauranteed
to have a collision. This PR fixes it by prepending
a unique rowid to each random promo code.
Release note (cli change): This PR fixes a potential error
occurring when loading the movr dataset with a large number
of rows in the promo codes column.