config/zonepb: increase default range size from 64/16 MB to 512/128 MB #45209
Conversation
…28MB This change increases the default range size by a factor of 8. There has been a good bit of manual testing at a much larger configuration of 64/16GB. At that configuration several issues were observed and will continue to be worked through. At this size no negative implications are anticipated. Release note (general change): New clusters will have a larger default range size which should enable greater storage density.
|
This change is |
ajwerner
changed the title
|
bors r=knz |
|
Note that your release note still mentions "greater storage density" although you had reservations about that yesterday. Do you want to add more words to be more specific about what users can expect? The docs team will welcome that too. |
|
bors r- |
Canceled |
I've made the note more vague. I would like to revise it with the docs team after we gather more data on the true implications. |
|
bors r=knz |
45209: config/zonepb: increase default range size from 64/16 MB to 512/128 MB r=knz a=ajwerner This change increases the default range size by a factor of 8. There has been a good bit of manual testing at a much larger configuration of 64/16GB. At that configuration several issues were observed and will continue to be worked through. At this size no negative implications are anticipated. Release note (general change): New clusters will have a larger default range size which will result in fewer ranges for the same amount of data. Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>
Build succeeded |
…e size In cockroachdb#45209 we increased the default range size. The test used hard-codes values. This commit looks up the expected values from the database. Fixes cockroachdb#37822. Release note: None
45451: roachtest: fix copy/bank for new range sizes r=nvanbenschoten a=ajwerner In #45209 we increased the default range size. The test used hard-codes values. This commit looks up the expected values from the database. Fixes #37822. Release note: None Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>
|
@ajwerner FYI the release notes script only picks up release note text from git commits, not the PR description in the Github UI. I updated the release note to match your text, with one change to specify the range size. So it will look like this:
If you want to discuss more I can tag you when I make the release notes PR in a bit. |
|
20.1 beta 2 release notes PR is here, if you want any changes to the wording in addition to that I shared above: cockroachdb/docs#6715 |
|
Thanks @rmloveland, this all SGTM! |
This change increases the default range size by a factor of 8.
There has been a good bit of manual testing at a much larger
configuration of 64/16GB. At that configuration several issues
were observed and will continue to be worked through. At this size
no negative implications are anticipated.
Release note (general change): New clusters will have a larger default
range size which will result in fewer ranges for the same amount of data.