storage: fix bug in calcRangeCounter #45253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
force-pushed
the
range-counter
branch
2 times, most recently
from
5a2fc5c
to
dbf19c6
Compare
|
Fixed this up and added (admittedly quite rudimentary) test, PTAL. |
andreimatei
approved these changes
Mar 2, 2020
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei and @tbg)
pkg/storage/replica_metrics_test.go, line 37 at r1 (raw file):
ctr, down, under, over := calcRangeCounter(1100 /* storeID */, desc, IsLiveMap{ 1000: IsLiveMapEntry{IsLive: true}, // by NodeID }, 4, 3)
why did you need a 4 here, as opposed to 3?
Found by @andreimatei in cockroachdb#39936 (review) Release note (bug fix): a bug in the range metrics collection could fail to correctly identify a range that had lost quorum, causing it to not be reported via the "unavailable ranges" metric. This is now fixed.
|
I didn't, changed it to 3. TFTR bors r=andreimatei |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by @andreimatei in #39936 (review)
Release note (bug fix): a bug in the range metrics collection could fail
to correctly identify a range that had lost quorum, causing it to not be
reported via the "unavailable ranges" metric. This is now fixed.