Ajwerner/schemafeed leases rebase #45257
Draft
+4,401
−1,745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… scoped leases This is a very WIP implementation of transaction scoped locks. The interface is garbage and not very considered. Nevertheless it seems to mostly work. The biggest problem I see so far is that at high concurrency there are cases where a lock can lay down all of the relevant intents and then still fail to commit. This happens because the TS cache information is lost due to a lease transfer before the txn record is layed down. Such a possibility is a big problem for the lease use cases which assume that an intent will be valid until the transaction expires. To some extent this problem makes sense given the transaction expiration isn't well defined before the txn record has been written. Release note: None
- Txn.ForceHeartbeat() writes a transaction record. - Txn.ExpiryTimestamp() returns the current expiry timestamp. - TODOs for plumbing a special Intent that updates the ts cache when removed due to abort. Release note: None
More plumbing for special intent that updates ts cache. Remaining work is to somehow update the ts cache in cmd_resolve_intent.go and cmd_resolve_intent_range.go, Release note: None
Plumbing to update the ts cache when removing a "leasing intent". Release note: None
Send a struct on success channel. Release note: None
To be filled. Release note: None
Adds a pgadvisory.Session object that uses KV-level API to implement txn- and session-scoped advisory locks. Release note: None
Release note: None
Release note: None
Also fix some bugs in pgadvisory.Session. Release note: None
Release note: None
Also add useful information to all pg_advisory builtins. Release note: None
Release note: None
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.