Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: Bump pebble to 488fb5bfea764c8ba7f77b279d4faf6724939839 #45499

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

itsbilal
Copy link
Member

Things of note:

  • internal/intern: add string interning facility
  • internal/record: fix blockage when using min-sync-interval
  • internal/manifest: add FileMetadata.CreationTime
  • db: force flush of queued memtables when manually compacting
  • open: Add helper to get version of pebble last used to write

Release note: None.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

You didn't like #45458? I see that you picked up another commit here. I'll go ahead and close my PR.

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @petermattis and @sumeerbhola)

@itsbilal
Copy link
Member Author

Haha, my bad. I didn't realize that one was open - got buried in my inbox. Today's been an interesting day.

Thanks for the review!

@itsbilal
Copy link
Member Author

bors r+

1 similar comment
@itsbilal
Copy link
Member Author

bors r+

craig bot pushed a commit that referenced this pull request Feb 27, 2020
45499: vendor: Bump pebble to 488fb5bfea764c8ba7f77b279d4faf6724939839 r=itsbilal a=itsbilal

Things of note:
- internal/intern: add string interning facility
- internal/record: fix blockage when using min-sync-interval
- internal/manifest: add FileMetadata.CreationTime
- db: force flush of queued memtables when manually compacting
- open: Add helper to get version of pebble last used to write

Release note: None.

Co-authored-by: Bilal Akhtar <bilal@cockroachlabs.com>
@itsbilal
Copy link
Member Author

bors r+

Things of note:
- internal/intern: add string interning facility
- internal/record: fix blockage when using min-sync-interval
- internal/manifest: add FileMetadata.CreationTime
- db: force flush of queued memtables when manually compacting
- open: Add helper to get version of pebble last used to write

Release note: None.
@itsbilal
Copy link
Member Author

itsbilal commented Feb 28, 2020

Wow, something's really cursed with this commit and bors, so I did a no-change commit amend to change the SHA.

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 28, 2020

Build succeeded

@craig craig bot merged commit 861b4e0 into cockroachdb:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants