cli: report partial result rows in case of error #45872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Mar 9, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
Before this patch: ``` root@127.0.0.1:61756/defaultdb> select 1/(@1-10) from generate_series(1,11); ERROR: division by zero SQLSTATE: 22012 ``` After: ``` root@127.0.0.1:61756/defaultdb> select 1/(@1-10) from generate_series(1,11); ?column? --------------------------- -0.11111111111111111111 -0.125 -0.14285714285714285714 -0.16666666666666666667 -0.2 -0.25 -0.33333333333333333333 -0.5 -1 (9 rows) (error encountered after some results rows were delivered) ERROR: division by zero SQLSTATE: 22012 ``` Release note (cli change): In case some result rows have already been received from the server when an error is encountered, CockroachDB's SQL shell (`cockroach sql/demo`) now present both the result rows and the error in the output regardless of the selected table formatter. Previously, only the error was reported with some formatters, or both with other formatters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First half of the work for #45833. (The other half is delaying notices to the end - will send a different PR.)
Before this patch:
After:
Release note (cli change): In case some result rows have already been
received from the server when an error is encountered, CockroachDB's
SQL shell (
cockroach sql/demo) now present both the result rows andthe error in the output regardless of the selected table
formatter. Previously, only the error was reported with some
formatters, or both with other formatters.