importccl: Improve error messages when importing mysql dump. #45958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Fixes #29625 |
|
|
dt
approved these changes
Mar 10, 2020
Improve error reporting when importing mysql tables
using unsupported features (such as fulltext index).
Prior to this change, if we attempt to import:
CREATE TABLE posts (
id INT NOT NULL AUTO_INCREMENT,
title VARCHAR(255) NOT NULL,
body TEXT,
PRIMARY KEY (id),
FULLTEXT KEY (body )
)
We would receive an error message:
error executing 'IMPORT TABLE posts FROM MYSQLDUMP ($1)':
pq: could not read definition for table "posts" (possible unsupported type?)
After this change, the error reporting improves to:
error executing 'IMPORT TABLE posts FROM MYSQLDUMP ($1)': pq: mysql parse error:
syntax error at position 914 near 'fulltext'
Release justification: Bug fix; minor, low/no impact formatting
change in the error messages.
Release note: improve error messages when importing mysql dump data.
|
done
…On Tue, Mar 10, 2020 at 3:29 PM David Taylor ***@***.***> wrote:
***@***.**** approved this pull request.
commit message needs a Release Note
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#45958?email_source=notifications&email_token=ANA4FVF75M2MODSIKWTBHBLRG2IIHA5CNFSM4LFGHFJ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCYYDJ5I#pullrequestreview-372258037>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANA4FVC5SHSJXGDOY657F5TRG2IIHANCNFSM4LFGHFJQ>
.
|
|
Release note requires a category parenthetical |
|
bors r+ |
|
@miretskiy the release note here still looks malformed (it needs the categorization field for the script to group it). |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error reporting when importing mysql tables
using unsupported features (such as fulltext index).
Prior to this change, if we attempt to import:
CREATE TABLE posts (
id INT NOT NULL AUTO_INCREMENT,
title VARCHAR(255) NOT NULL,
body TEXT,
PRIMARY KEY (id),
FULLTEXT KEY (body )
)
We would receive an error message:
error executing 'IMPORT TABLE posts FROM MYSQLDUMP ($1)':
pq: could not read definition for table "posts" (possible unsupported type?)
After this change, the error reporting improves to:
error executing 'IMPORT TABLE posts FROM MYSQLDUMP ($1)': pq: mysql parse error:
syntax error at position 914 near 'fulltext'
Release justification: Bug fix; minor, low/no impact formatting
change in the error messages.