cli/sql: fix the handling of --set #46118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
force-pushed
the
20200314-cli-opts
branch
2 times, most recently
from
70f36d8
to
c54347a
Compare
rohany
reviewed
Mar 14, 2020
pkg/cli/sql.go
Outdated
| sqlCtx.showTimes = true | ||
| } | ||
| if cliCtx.isInteractive && !sqlCtx.debugMode { | ||
| // If the terminal is interactive and this was not explicitly disabled by setting the debug mode, |
yes |
|
lgtm |
Release justification: Category 2: Bug fixes and low-risk updates to new functionality Release note (bug fix): The parameter `--set` for `cockroach sql` and `cockroach demo` is now properly able to override all client-side options, as advertised.
|
TFYR bors r=rohany |
Canceled |
|
bors r=rohany |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46116
I intend to backport this to 19.2 (bug fix)
Release justification: Category 2: Bug fixes and low-risk updates to new functionality
Release note (bug fix): The parameter
--setforcockroach sqlandcockroach demois now properly able to override all client-sideoptions, as advertised.