opt: allow qualified star without FROM clause #46233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rytaft
approved these changes
Mar 18, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
We incorrectly error out if we have a qualified star without a FROM clause; the star can refer to an outer table. We also incorrectly take the columns from the input scope which is not necessarily the scope that the star is referring to. Unfortunately, in the specific case in cockroachdb#45855 (`SELECT (SELECT t.*)`) we don't get the nice column name `x` like in postgres; we get `?column?`. This is because in our code the aliases are determined before building the expressions; this seems complicated to change. Fixes cockroachdb#45855. Release note (bug fix): queries with qualified stars that refer to tables in outer scopes now work. Release justification: low risk changes to existing functionality.
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We incorrectly error out if we have a qualified star without a FROM clause; the
star can refer to an outer table. We also incorrectly take the columns from the
input scope which is not necessarily the scope that the star is referring to.
Unfortunately, in the specific case in #45855 (
SELECT (SELECT t.*)) we don'tget the nice column name
xlike in postgres; we get?column?. This isbecause in our code the aliases are determined before building the expressions;
this seems complicated to change.
Fixes #45855.
Release note (bug fix): queries with qualified stars that refer to tables
in outer scopes now work.
Release justification: low risk changes to existing functionality.