sql: change %f to microseconds for experimental_str{f,p}time #46263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
force-pushed
the
experimental_strftime_6digf
branch
from
8c2ca53
to
d36a811
Compare
|
i think you haven't committed the vendor change properly |
otan
force-pushed
the
experimental_strftime_6digf
branch
from
d36a811
to
585b71d
Compare
yeah and once i committed it i couldn't add it again without the whole commit :\ submodules are weird |
knz
approved these changes
Mar 19, 2020
|
bors r=knz |
Build failed (retrying...) |
Build failed |
|
bors r=knz |
Merge conflict (retrying...) |
|
bors r- merge conflict grumble |
Canceled |
otan
force-pushed
the
experimental_strftime_6digf
branch
from
585b71d
to
aaf50cd
Compare
Release justification: low risk, high benefit changes to existing functionality (open to waiting until 20.2) Release note (bug fix, sql change): Previously, experimental_strftime and experimental_strptime used the non-POSIX standard %f for nanosecond display. However, as cockroach only supports up to microsecond precision and python's strftime has %f to microsecond, we have similarly switched %f to use microsecond instead of nanosecond precision.
otan
force-pushed
the
experimental_strftime_6digf
branch
from
aaf50cd
to
fc3b498
Compare
|
bors r=knz |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #45881
Release justification: low risk, high benefit changes to existing
functionality (open to waiting until 20.2)
Release note (bug fix, sql change): Previously, experimental_strftime
and experimental_strptime used the non-POSIX standard %f for nanosecond
display. However, as cockroach only supports up to microsecond precision
and python's strftime has %f to microsecond, we have similarly switched
%f to use microsecond instead of nanosecond precision.