sql, workload, compose: miscellaneous cleanups #46279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release justification: low-risk new functionality. Release note (sql change): CockroachDB now supports `stddev_samp` aggregate builtin function which is the same as `stddev` (actually, the latter is the historical alias of the former, according to Postgres documentation).
Release justification: non-production code changes. This commit cleans up a few things: 1. we recently renamed `experimental_on` vectorize setting to `on`, but a couple of places were missed. 2. compose-compare test (of randomized land) was skipping some queries due to bugs which have been fixed. 3. `tpcds` workload has been slightly enhanced (added `vectorize` option and refactored the way statement timeout is set). Release note: None
|
This change is |
asubiotto
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, 4 of 4 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
TFTR! bors r+ |
Build failed |
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql: add stddev_samp alias for stddev aggregate builtin
Release justification: low-risk new functionality.
Addresses: #37464.
Release note (sql change): CockroachDB now supports
stddev_sampaggregate builtin function which is the same as
stddev(actually, thelatter is the historical alias of the former, according to Postgres
documentation).
workload, compose: miscellaneous cleanups
Release justification: non-production code changes.
This commit cleans up a few things:
experimental_onvectorize setting toon, buta couple of places were missed.
due to bugs which have been fixed.
tpcdsworkload has been slightly enhanced (addedvectorizeoptionand refactored the way statement timeout is set).
Release note: None