Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workload: set application_name #46546

Merged
merged 1 commit into from
Mar 26, 2020
Merged

workload: set application_name #46546

merged 1 commit into from
Mar 26, 2020

Conversation

dt
Copy link
Member

@dt dt commented Mar 25, 2020

Release note: none.

Release justification: low-risk, non-production code.

@dt dt requested a review from jordanlewis March 25, 2020 03:18
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dt
Copy link
Member Author

dt commented Mar 25, 2020

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 25, 2020

Timed out

@knz
Copy link
Contributor

knz commented Mar 25, 2020

I recommend a release note:

Release note (cli change): The `workload` command now sets its `application_name` to XXX, which facilitates recognition of its queries in the web UI.

@knz knz added this to To do in DB Server & Security via automation Mar 25, 2020
Release note (cli change): The `workload` command now sets its `application_name` to based on the chosen workload.

Release justification: low-risk, non-production code.
@dt
Copy link
Member Author

dt commented Mar 25, 2020

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 25, 2020

Build failed (retrying...)

@craig
Copy link
Contributor

craig bot commented Mar 25, 2020

Build failed (retrying...)

@dt
Copy link
Member Author

dt commented Mar 25, 2020

bors r+

another day, another fight with bors.

@craig
Copy link
Contributor

craig bot commented Mar 25, 2020

Already running a review

@knz
Copy link
Contributor

knz commented Mar 26, 2020

@dt if it says "retrying" you don't have to poke it, it will simply do it again (later)

@dt
Copy link
Member Author

dt commented Mar 26, 2020

yeah, sometimes it says that but never comes back. This time I guess it was dutifully still actually retrying though.

@craig
Copy link
Contributor

craig bot commented Mar 26, 2020

Build succeeded

@craig craig bot merged commit b7d0984 into cockroachdb:master Mar 26, 2020
DB Server & Security automation moved this from To do to Done 20.1 Mar 26, 2020
@dt dt deleted the workload-name branch March 31, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants