release-20.1: colrpc: reduce Outbox Next error logging verbosity #46838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release justification: low risk, high benefit change. Eliminates noisy log messages in default logging configuration. We would previously log any error that happened when calling Next on an Outbox's input tree. This could include expected errors such as context cancellations, making the resulting log output (including a stack trace) pretty scary. This commit puts this logging behind a verbosity(1) flag. Release note (bug fix): benign Outbox Next errors are now only logged when log verbosity is set to 1 or greater.
|
This change is |
yuzefovich
approved these changes
Apr 1, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #46724.
/cc @cockroachdb/release
Release justification: low risk, high benefit change. Eliminates noisy log
messages in default logging configuration.
We would previously log any error that happened when calling Next on an
Outbox's input tree. This could include expected errors such as context
cancellations, making the resulting log output (including a stack trace) pretty
scary. This commit puts this logging behind a verbosity(1) flag.
Release note (bug fix): benign Outbox Next errors are now only logged when log
verbosity is set to 1 or greater.