colexec: rename vectorize setting 192auto to auto and make it the default #46845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
…ault This commit renames 192auto back to auto and makes it the default, so that only streaming vectorized operators will be planned by default. The previous auto setting would also plan operators that can spill to disk. This is now removed and they can be run using the "on" setting. Release note (sql change): the vectorized execution engine will only run queries with streaming operators. SET vectorize=on to enable the vectorized execution engine for buffering operators.
This commit will only allow JoinReaders to be part of a colexec flow when vectorize=auto. Release note: None (no observable user change)
yuzefovich
approved these changes
Apr 1, 2020
There was a problem hiding this comment.
Reviewed 30 of 30 files at r1, 20 of 20 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @asubiotto and @jordanlewis)
pkg/sql/sessiondata/session_data.go, line 270 at r1 (raw file):
// streaming operators (i.e. those that do not require any buffering) will // be run using the columnar execution. If any part of a query is not // supported by the vectorized execution engine, the whole query will fall
nit: this comment is slightly misleading since we're wrapping index and lookup joins, but I'm not sure whether it's worth calling out. Probably not. Never mind.
|
bors r=yuzefovich |
Build failed |
|
The failure seems like a hard to hit float precision issue that we've run into before: https://github.com/cockroachdb/cockroach/pull/37600/files. We should probably take care of that in a separate PR. |
|
bors r- |
|
bors r=yuzefovich |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will be backported to 20.1. A followup PR will make "on" the default for master. Check the commits for more details.
This PR also disables processor wrapping for all processors when
vectorize=autoapart from the JoinReader, since this is in line with 19.2 behavior.Release note: None