ui: Link from statement diagnostics to details page #46923
Conversation
|
This change is |
|
We have Statements diagnostics history page with list of all requested diagnostics. Before, statement fingerprint were represented as a simple text and now it is a links to statement details page. One notion, that it is possible to have diagnostics for statements which is already cleared. In this case statement is displayed as a text instead of link. Release note (admin ui change): Add links to statement details from Statement Diagnostics history page. Release justification: bug fixes and low-risk updates to new functionality
Before, statements column on Statements diagnostics history page displayed full statement and didn't have tooltips. With current changes, statements column behave almost the same way as on Statements page: - statement is shortened - tooltip is added with full statement - in case shortened statement is the same as full statement - then don't display tooltip at all. Release note (admin ui change): Add tooltips with full length statements on Statement diagnostics history page. Release justification: bug fixes and low-risk updates to new functionality
koorosh
force-pushed
the
ui-statements-diagnostics-history--links
branch
from
edbf98b
to
6e210c3
Compare
|
Additional change is applied, now statements column looks and behave almost the same
|
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @koorosh and @nathanstilwell)
pkg/ui/src/views/reports/containers/statementDiagnosticsHistory/index.tsx, line 79 at r1 (raw file):
return ( <Link to={ `/statement/${implicitTxn}/${encodeURIComponent(query)}` }
Given the fact that this will be used outside of this repo, can we extract the creation of this link?
I would consider this as a separate more global task, probably in scope of routes and the way we provide/consume configuration. |
There was a problem hiding this comment.
Appreciate the comment! We can address later.
Reviewable status:
|
bors r+ |
Build succeeded |
Resolves: #46559
We have Statements diagnostics history page with list
of all requested diagnostics.
Before, statement fingerprint were represented as a
simple text and now it is a links to statement details
page.
One notion, that it is possible to have diagnostics for
statements which is already cleared. In this case
statement is displayed as a text instead of link.
Release note (admin ui change): Add links to statement
details from Statement Diagnostics history page.
Release justification: bug fixes and low-risk updates to new functionality