release-20.1: backupccl: prevent automatically narrowing full backups #46966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new backup UX that allows appending incrementals by re-specifying paths makes it easy to accidentally 'narrow' a backup, by backing up a single table or database to a location that contains a existing backup of a additional tables, databases or a full-cluster. In such a case, it would then base that original backup impossible to appended to covering its original scope, i.e. to do an incremental full-cluster backup, since the single table/db incremental layer would be the most recent layer from which new layers would be based, but would not contain the rest of the cluster/dbs that were in the base. Narrowing or backing up different things at different cadences to different places falls under what we are considering 'advanced' usage and can continue using the existing syntax, as it is flexible enough to support such cases. However 'basic' usage -- just backup my cluster somewhere -- with the new syntax should reject narrowing as it is an easy way to mess up your backup routine. Release note (enterprise change): the new appended incremental backup syntax does not allow converting a full cluster backup to a specific table or database backup.
|
This change is |
pbardea
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #46864.
/cc @cockroachdb/release
The new backup UX that allows appending incrementals by re-specifying paths
makes it easy to accidentally 'narrow' a backup, by backing up a single table
or database to a location that contains a existing backup of a additional
tables, databases or a full-cluster. In such a case, it would then base that
original backup impossible to appended to covering its original scope, i.e.
to do an incremental full-cluster backup, since the single table/db incremental
layer would be the most recent layer from which new layers would be based, but
would not contain the rest of the cluster/dbs that were in the base.
Narrowing or backing up different things at different cadences to different
places falls under what we are considering 'advanced' usage and can continue
using the existing syntax, as it is flexible enough to support such cases.
However 'basic' usage -- just backup my cluster somewhere -- with the new
syntax should reject narrowing as it is an easy way to mess up your backup
routine.
Fixes #46737.
Release note (enterprise change): the new appended incremental backup syntax does not allow converting a full cluster backup to a specific table or database backup.