release-19.2: sql: improve "couldn't find With expression" error #46971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a known issue where apply joins cannot reference top-level WITH expressions. I improved the error messaging in this case by changing it from a panic to an error and adding a hint about what's going on. Fixes cockroachdb#42373 Release note (sql change): improve error message for unsupported interaction between correlated subqueries and WITH clauses
|
This change is |
|
LGTM |
This was referenced Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #45227.
/cc @cockroachdb/release
There is a known issue where apply joins cannot reference top-level WITH
expressions. I improved the error messaging in this case by changing it
from a panic to an error and adding a hint about what's going on.
Fixes #42373
Fixes: #46961.
Release note: None