Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/sem: properly copy SelectClause.Window in copyNode #47146

Merged
merged 1 commit into from
Apr 7, 2020
Merged

sql/sem: properly copy SelectClause.Window in copyNode #47146

merged 1 commit into from
Apr 7, 2020

Commits on Apr 7, 2020

  1. sql/sem: properly copy SelectClause.Window in copyNode 

    Found while stressing cockroachdb#46793.

The bug was introduced here: cockroachdb@fabd5c1#diff-2be097dd2faa900531667063b2870a55R1102.
This fix will need to be backported all the way back to v2.1.0.

Release note (bug fix): fix a data race on AST nodes for SELECT
statements that include a WINDOW clause. It is unclear whether this
could have resulted in incorrect results being returned for these
queries.
    @nvanbenschoten
    nvanbenschoten committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    86a1485 View commit details
    Browse the repository at this point in the history