Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: forbid TIMETZ during mixed 19.2/20.1 node clusters #47156

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

otan
Copy link
Contributor

@otan otan commented Apr 7, 2020

Resolves #47110.

Release note (bug fix): This PR fixes a bug preventing clusters from
creating TIMETZ columns before they accept 20.1 without downgrading.

@otan otan requested review from jordanlewis, rohany and a team April 7, 2020 22:15
@blathers-crl
Copy link

blathers-crl bot commented Apr 7, 2020

Welcome back, creator. Thank you for testing me.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. I am experimental - my owner is otan.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Release note (bug fix): This PR fixes a bug preventing clusters from
creating TIMETZ columns before they accept 20.1 without downgrading.
@blathers-crl
Copy link

blathers-crl bot commented Apr 7, 2020

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. I am experimental - my owner is otan.

@rohany
Copy link
Contributor

rohany commented Apr 8, 2020

can you verify that spas's bug isn't reproducible with this change

@otan
Copy link
Contributor Author

otan commented Apr 8, 2020

bors r=rohany

i'll give it a go, but i think this should be a backport for sure so expediting it.

@craig
Copy link
Contributor

craig bot commented Apr 8, 2020

Build succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

running workload/schemachange causes 19.2 node in mixed version cluster to crash
3 participants